[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19756ef53a49: [OpenMP][IRBuilder] Support allocas in nested parallel regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim accepted this revision. fghanim added a comment. This revision is now accepted and ready to land. Great. Thank you! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert updated this revision to Diff 278952. jdoerfert added a comment. Reuse builder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 - Builder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI()); - AllocaInst *TIDAddr = Builder.CreateAlloca(Int32, nullptr, "tid.addr"); - AllocaInst *ZeroAddr =

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 - Builder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI()); - AllocaInst *TIDAddr = Builder.CreateAlloca(Int32, nullptr,

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added a comment. > I'll address the nits. Thanks :) > Unsure if that is all. depends on the comment about `AllocaBuilder` Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 - Builder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI()); - AllocaInst

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert marked an inline comment as done. jdoerfert added a comment. I'll address the nits. Unsure if that is all. I also don't get the one comment. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 -

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added a comment. Thanks for the update. Just a couple of Nits, and a quick note Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:288 struct OutlineInfo { -SmallVector Blocks; using PostOutlineCBTy = std::function; Nit: isn't

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert added a comment. Used an extra argument now. Please let me know if this is OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 ___ cfe-commits

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert updated this revision to Diff 277634. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings jdoerfert wrote: > fghanim wrote: > > jdoerfert wrote: > > > fghanim wrote: > > > >

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings fghanim wrote: > jdoerfert wrote: > >

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim requested changes to this revision. fghanim added inline comments. This revision now requires changes to proceed. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

SouraVX accepted this revision. SouraVX added a comment. This revision is now accepted and ready to land. In D82470#2118814 , @jdoerfert wrote: > In D82470#2116581 , @SouraVX wrote: > > > Overall this seems great

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert updated this revision to Diff 273961. jdoerfert edited the summary of this revision. jdoerfert added a comment. restrict this to the alloca support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470