[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-08-31 Thread Julian Lettner via Phabricator via cfe-commits
yln added inline comments. Comment at: llvm/docs/CommandGuide/lit.rst:102 + + Alias for ``-v``/``--verbose`` (for backwards compatibility). .. option:: -a, --show-all blank line Comment at: llvm/utils/lit/lit/OutputSettings.py:34 +ONLY_FAILING

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-07-26 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple added a comment. Some of the changes probably don't make perfect sense in this revision because I initially started out with the whole change being one revision and then split things into commits, while trying to minimize the churn between revisions. Please also take a look at

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-07-26 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple updated this revision to Diff 280786. varungandhi-apple marked 11 inline comments as done. varungandhi-apple added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82791/new/ https://reviews.llvm.o

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-07-06 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple marked 2 inline comments as done. varungandhi-apple added a comment. Thanks for the review, it's a big patch. 😅 I'm a bit busy at the moment, I will respond to the other comments later this week or sometime next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-07-06 Thread Julian Lettner via Phabricator via cfe-commits
yln added a comment. The changes here are for text printed for failing tests, right? And `showAllOutput` is orthogonal and just shows everything even for non-failing tests? Comment at: llvm/utils/lit/lit/OutputSettings.py:34 +ONLY_FAILING_COMMAND = CommandOutputStyle("OnlyFail

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-07-01 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple updated this revision to Diff 274865. varungandhi-apple added a comment. Rebase after changes in D82808 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82791/new/ https://reviews.llvm.org/D82791 F

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-06-29 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple updated this revision to Diff 274240. varungandhi-apple added a comment. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. Include missing commit separating verbose and showOutput. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-06-29 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple updated this revision to Diff 274242. varungandhi-apple added a comment. - [docs] [lit] Add a more helpful description for lit.py's -s flag. - [NFC] [lit] Separate verbose and showOutput. - [lit] Improve lit's output with default settings and --verbose. Repository: rG LLVM Gi