[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

hoyFB added a comment. In D82822#2189692 , @jdoerfert wrote: > In D82822#2189366 , @hoyFB wrote: > >> In D82822#2187576 , @jdoerfert >> wrote: >> >>> @davezarzycki The bots

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

jdoerfert added a comment. In D82822#2189366 , @hoyFB wrote: > In D82822#2187576 , @jdoerfert wrote: > >> @davezarzycki The bots reported this as well, didn't build MLIR locally, >> this should have been fixed by 4

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

hoyFB added a comment. In D82822#2187576 , @jdoerfert wrote: > @davezarzycki The bots reported this as well, didn't build MLIR locally, this > should have been fixed by 4d83aa4771d84940626d86c883193af390812281 >

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

jdoerfert added a comment. @davezarzycki The bots reported this as well, didn't build MLIR locally, this should have been fixed by 4d83aa4771d84940626d86c883193af390812281 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

davezarzycki added a comment. Hello, I have a twice-daily auto-bisecting multi-stage cron job running on Fedora 32 (x86-64) that has identified this commit as failing my first stage test (release + no asserts). Is this expected? Can we get a quick fix or revert this? FAIL: Clang :: OpenMP/irbu

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebad64dfe133: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

jdoerfert updated this revision to Diff 277635. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82822/new/ https://reviews.llvm.org/D82822 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/cancel_co

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

fghanim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82822/new/ https://reviews.llvm.org/D82822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

anchu-rajendran accepted this revision. anchu-rajendran added a comment. This revision is now accepted and ready to land. LGTM :). Thanks! Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1543 +OMPBuilder->getOrCreateIdent(SrcLocStr)); + } Nit: I th

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

jdoerfert created this revision. jdoerfert added reviewers: anchu-rajendran, kiranktp, fghanim. Herald added subscribers: sstefan1, guansong, bollu, yaxunl. Herald added a project: clang. When we use the OpenMPIRBuilder for the parallel region we need to also use it to get the thread ID (among oth