[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-13 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Thank you for the heads-up. It seems like Clang 5 didn't like the usage of `static constexpr` member via an instance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-11 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Reverted in f917356f9ce0 ; I suspect a `static constexpr` in a class missing a definition out of class (required pre-c++17). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D82860#2388916 , @jpienaar wrote: > This seems to breaking clang-5 builds: > > utils/TableGen/CMakeFiles/llvm-tblgen.dir/OptParserEmitter.cpp.o: In function > `llvm::EmitOptParser(llvm::RecordKeeper&, llvm::raw_ostream&)':

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-11 Thread Jacques Pienaar via Phabricator via cfe-commits
jpienaar added a comment. This seems to breaking clang-5 builds: utils/TableGen/CMakeFiles/llvm-tblgen.dir/OptParserEmitter.cpp.o: In function `llvm::EmitOptParser(llvm::RecordKeeper&, llvm::raw_ostream&)':

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-11 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG09248a5d25bb: [clang][cli] Port ObjCMTAction to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-10 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 ___ cfe-commits mailing list

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-09 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 requested review of this revision. jansvoboda11 added a comment. WDYT @Bigcheese? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-09 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 303828. jansvoboda11 added a comment. Rebase on top of D82756 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang/Driver/Options.td

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-11-09 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking control of this revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-08-19 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-07-07 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 276008. dang added a comment. Make mergers use values directly instead of constant references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files:

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-07-02 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 275171. dang added a comment. Ensure that `mergeForwardValue` can accept default values whose type doesn't quite match the associated keypath. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-07-01 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 274736. dang added a comment. Remove the need for the merger and extractor to be macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files:

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-06-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 274425. dang added a comment. Denormalizer should also use the extractor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang/Driver/Options.td

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-06-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:328-331 + HelpText<"Enable migration to modern ObjC literals">, + MarshallingInfoFlag<"FrontendOpts.ObjCMTAction", "0", "unsigned">,

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-06-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith. Herald added projects: clang, LLVM. dang marked an inline comment as done. dang added inline comments. Comment at: