gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/CXXOperatorCallExprTest.cpp:21
+ const std::string Code = R"cpp(
+ struct X{
+friend X operator+(X, X);
Please add a space before "{".
Comment at:
eduucaldas updated this revision to Diff 275325.
eduucaldas added a comment.
Remove review formatting noise
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82937/new/
https://reviews.llvm.org/D82937
Files:
clang/include/clang/AST/ExprCXX.h
eduucaldas updated this revision to Diff 275317.
eduucaldas added a comment.
Nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82937/new/
https://reviews.llvm.org/D82937
Files:
clang/include/clang/AST/ExprCXX.h
clang/lib/AST/ExprCXX.cpp
eduucaldas updated this revision to Diff 274769.
eduucaldas added a comment.
better comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82937/new/
https://reviews.llvm.org/D82937
Files:
clang/lib/AST/ExprCXX.cpp
eduucaldas added a reviewer: gribozavr2.
eduucaldas marked 2 inline comments as done.
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/CXXOperatorCallExprTest.cpp:1
+//===- unittests/Tooling/CXXOperatorCallExprTest.cpp
--===//
+//
eduucaldas updated this revision to Diff 274720.
eduucaldas added a comment.
nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82937/new/
https://reviews.llvm.org/D82937
Files:
clang/lib/AST/ExprCXX.cpp
clang/unittests/Tooling/CMakeLists.txt
eduucaldas created this revision.
Herald added subscribers: cfe-commits, mgorny.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D82937
Files:
clang/lib/AST/ExprCXX.cpp
clang/unittests/Tooling/CMakeLists.txt
