[PATCH] D83071: Add support for options with two flags for controlling the same field.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f3055c543f8: [clang][cli] Add support for options with two flags for controlling the same… (authored by jansvoboda11). Changed prior to commit: h

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 updated this revision to Diff 304491. jansvoboda11 added a comment. Apply unique_ptr workaround for older Clang versions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/c

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 updated this revision to Diff 304487. jansvoboda11 added a comment. Rebase on top of recent changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking control of this revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.l

[PATCH] D83071: Add support for options with two flags for controlling the same field.

Bigcheese accepted this revision. Bigcheese added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 280945. dang added a comment. Update with latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td clang/lib/Fronten

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 276400. dang added a comment. Split into two macro kinds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td clang/lib/Fronte

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 276009. dang added a comment. Rebase on top of some changes to parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 276007. dang added a comment. Make mergers use values directly instead of constant references Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3931-3932 if (((FLAGS)&options::CC1Option) && \ (ALWAYS_EMIT || EXTRACTOR(this->KEYPATH) != DEFAULT_VALUE))

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 275591. dang marked an inline comment as done. dang added a comment. Address some code review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/incl

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang marked 5 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:150 -static llvm::Optional normalizeSimpleEnum(OptSpecifier Opt, -unsigned TableIndex, d

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 275586. dang added a comment. Revert accidental namespace removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:150 -static llvm::Optional normalizeSimpleEnum(OptSpecifier Opt, -

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This enables automatically parsing and generating CC1 arguments for options where two flags control the same field, e.g. -fexperimenta