[PATCH] D83286: [analyzer][solver] Track symbol disequalities

This revision was automatically updated to reflect the committed changes. Closed by commit rGe63b488f2755: [analyzer][solver] Track symbol disequalities (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D83286?vs=276729=279747#toc Repository: rG LLVM Github

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

xazax.hun added a comment. In D83286#2149912 , @vsavchenko wrote: > @xazax.hun You were interested in performance ⏫ > > These results here compare this patch together with D82445 > against **master**. This is really

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. @xazax.hun You were interested in performance ⏫ These results here compare this patch together with D82445 against **master**. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. >> Maybe spend a few minutes remeasuring `libsoundio` more carefully, just in >> case? > > Sure, will do! It turns out that **libsoundio** has a problem similar to **re2** and varies a lot in terms of the analysis time (probably we can even try to figure out some

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. In D83286#2148787 , @NoQ wrote: > Data  Thanks  These tables are already generated by a script and I plan to make it into **a phabricator reporter**, so it is easier to put all the data we need here. > Maybe spend a few

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Data  Maybe spend a few minutes remeasuring `libsoundio` more carefully, just in case? Also i really wish we had per-TU data of that kind, to see if any particular TUs have regressed

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. Introduction I have some test results with execution times. Because the execution time varies from one execution to another, I've measured performance on master twice (I know that it's not very conclusive) to show that equivalence tracking doesn't

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko updated this revision to Diff 276729. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/ https://reviews.llvm.org/D83286 Files:

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko added a comment. In D83286#2138734 , @ASDenysPetrov wrote: > Did you take into account that e.g. `a > b` also is a disequality. It is a very good point! I didn't take them into account (yet?) because they make the implementation a bit

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

ASDenysPetrov added a comment. @vsavchenko > if a != b and b == C where C is a constant, a != C Did you take into account that e.g. `a > b` also is a disequality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

NoQ added a comment. This looks great to me but i'd very much rather have someone else have a look, just because of the nature of the problem (: Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1586 + // 4. Update disequality relations + if (const

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko updated this revision to Diff 275957. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/ https://reviews.llvm.org/D83286 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, ASDenysPetrov, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. This