[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa59d4ae4313c: [Analyzer] Hotfix for various crashes in iterator checkers (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8329

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware updated this revision to Diff 278394. baloghadamsoftware added a comment. Protection against `Unknown` added for pointer increments and decrements. No more crashes on `LLVM/Clang`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D832

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware updated this revision to Diff 277340. baloghadamsoftware edited the summary of this revision. baloghadamsoftware added a comment. Two more crashes detected, fixes for them added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D83295

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

Szelethus accepted this revision. Szelethus added a comment. LGTM, but if we knowingly a subpar solution, we should make that clear in the surrounding code. I know the followup patch is around the corner, but just to be sure. Comment at: clang/lib/StaticAnalyzer/Checkers/Iter

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

gamesh411 added a comment. @Szelethus thanks for being watchful, appreciated c: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D83295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

gamesh411 accepted this revision. gamesh411 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if (!BO->getRHS()->getType()->isInte

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if (!BO->getRHS()->getType()->isIntegralOrEnumerationType

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if (!BO->getRHS()->getType()->isIntegralOrEnumerationType()) + return; handlePtrIncrOrDecr(C, BO->getLHS(), -

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware updated this revision to Diff 276684. baloghadamsoftware edited the summary of this revision. baloghadamsoftware added a comment. Test added for the third fix in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D83295 File

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, gamesh411, martong, balazske. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xaza