[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff220de9009: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8340

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:328-329 struct Signature { -const ArgTypes ArgTys; -const QualType RetTy; +ArgTypes ArgTys; +QualType RetT

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:328-329 struct Signature { -const ArgTypes ArgTys; -const QualType RetTy; +ArgTypes ArgTys; +QualType RetTy;

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus marked an inline comment as done. Szelethus added a comment. I'm yet to go over line-by-line, but the overall logic looks great. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:328-329 struct Signature { -const ArgTypes ArgTys; -

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong updated this revision to Diff 276928. martong marked an inline comment as done. martong added a comment. - Make Signature to be an Optional member of the Summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, +

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong updated this revision to Diff 276759. martong added a comment. - Reuse summaries with accept and other functions when sockaddr is a union of pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, + *

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, +

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, + *

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong added a comment. In D83407#2141075 , @balazske wrote: > Are not some functions missing from the list (`shutdown`, `sockatmark`, > `socket`) (these come from )? And `getnameinfo` comes from > with many other functions that are not added.

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong updated this revision to Diff 276716. martong marked 2 inline comments as done and an inline comment as not done. martong added a comment. - Remove redundant line from test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong updated this revision to Diff 276715. martong added a comment. - Add getRestrictTy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsCheck

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

balazske added a comment. Are not some functions missing from the list (`shutdown`, `sockatmark`, `socket`) (these come from )? And `getnameinfo` comes from with many other functions that are not added. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctio

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-POSIX.c:200 +#define __SOCKADDR_ONETYPE(type) struct type *__restrict __##type##__; +#define __SOCKADDR_ONETYPE(type) struct type *__restrict __##type#

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong created this revision. martong added reviewers: gamesh411, Szelethus, NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang.