[PATCH] D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects

jkorous added a comment. Sounds like a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83438/new/ https://reviews.llvm.org/D83438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects

riccibruno added a comment. I think that adding an unittest for such a simple fix is a bit heavy handed. What about just exercising this code path. For example: void Test(int N) { int arr[N]; decltype([]{}) *p; // expected-error {{lambda expression in an unevaluated operand}} }

[PATCH] D83438: [AST] Fix potential nullptr dereference in Expr::HasSideEffects

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdb69539bcd2: [AST] Fix potential nullptr dereference in Expr::HasSideEffects (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github