This revision was automatically updated to reflect the committed changes.
Closed by commit rGfc5530862870: [PowerPC][Power10] Fix VINS* (vector insert
byte/half/word) instructions to… (authored by amyk).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rzurob accepted this revision.
rzurob added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83497/new/
https://reviews.llvm.org/D83497
nemanjai added a comment.
@rzurob This cannot proceed without your approval since you requested changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83497/new/
https://reviews.llvm.org/D83497
___
nemanjai accepted this revision.
nemanjai added a comment.
LGTM aside from a minor nit regarding the description.
Comment at: clang/include/clang/Basic/BuiltinsPPC.def:324
// P10 Vector Insert built-ins.
-BUILTIN(__builtin_altivec_vinsblx, "V16UcV16UcULLiULLi", "")
bsaleil accepted this revision as: bsaleil.
bsaleil added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83497/new/
https://reviews.llvm.org/D83497
___
cfe-commits mailing list
amyk updated this revision to Diff 277153.
amyk retitled this revision from "[PowerPC][Power10] Fix the VINSW instruction
to have an i32 argument." to "[PowerPC][Power10] Fix VINS* (vector insert
byte/half/word) instructions to have i32 arguments.".
amyk edited the summary of this revision.
amyk
