[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG89e61e782b73: [Sema][AArch64] Add semantics for arm_sve_vector_bits attribute (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83551/new

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added a comment. In D83551#2164984 , @aaron.ballman wrote: > The attribute bits LGTM, thanks! Thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83551/new/ https://reviews.llvm.org/D83551 _

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The attribute bits LGTM, thanks! Comment at: clang/lib/AST/ASTContext.cpp:1887 + +unsigned getSvePredWidth(const Type *T) { return getSveVectorWidth(T) / 8; } +

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 279455. c-rhodes added a comment. - Make helpers static in ASTContext. - Use `getCharWidth`. - `s/vector-length-sized/vector-length-specific`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83551/new/ https://reviews.llvm.org/D83551 Files: clang/

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1887 + +unsigned getSvePredWidth(const Type *T) { return getSveVectorWidth(T) / 8; } + aaron.ballman wrote: > Should this be dividing by the number of bits in a char for the target as > opp

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added a comment. I like the way the code is shaping up with the slightly altered design, nice! Comment at: clang/lib/AST/ASTContext.cpp:1872 +unsigned getSveVectorWidth(const Type *T) { + // Get the vector size from the 'arm_sve_vector_bits' attribute via the -

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes marked an inline comment as done. c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; c-rhodes wrote: > aaron.ballman wrote: > > c-rhodes wrote: > > > aaron.bal

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 279178. c-rhodes added a comment. Changes: - Remove internal type attributes (defined for each vector-size). - Get the vector size from the `arm_sve_vector_bits` attribute via the `AttributedTypeLoc` associated with the typedef decl. - Change `NumBits` argu

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > c-rhodes wrote: > > aaron.ballman wrote: > > > c-rhodes wrote: > > > > c-rhodes wrote: > > > >

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; c-rhodes wrote: > aaron.ballman wrote: > > c-rhodes wrote: > > > c-rhodes wrote: > > > > aaron.ballman wrote: >

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > c-rhodes wrote: > > c-rhodes wrote: > > > aaron.ballman wrote: > > > > aaron.ballman wrote: >

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:1928 + /// Determines if this is vector-length sized typed (VLST), i.e. a + /// sizeless type with the 'arm_sve_vector_bits(N)' attribute applied. ... this is a vector-length-size

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; c-rhodes wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > c-rhodes wrote: > > > > sdesmalen wrote: > > >

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes marked 6 inline comments as done. c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > aaron.ballman wrote: > > c-rhodes wrote: > > > sdes

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278430. c-rhodes added a comment. Changes: - Documented internal type attributes. - Set `ASTNode = 0` on user-facing `ArmSveVectorBitsAttr` as the internal type attrs are used in the AST. Also removed the case for this from `TypePrinter`. - `getSveVectorWid

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; c-rhodes wrote: > sdesmalen wrote: > > aaron.ballman wrote: > > > sdesmalen wrote: > > > > nit: Can you add a co

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; sdesmalen wrote: > aaron.ballman wrote: > > sdesmalen wrote: > > > nit: Can you add a comment saying why these are un

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > sdesmalen wrote: > > nit: Can you add a comment saying why these are undocumented (and have n

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; sdesmalen wrote: > nit: Can you add a comment saying why these are undocumented (and have no > spellings) Also,

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; nit: Can you add a comment saying why these are undocumented (and have no spellings) Comment at:

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, rsandifo-arm, efriedma, cameron.mcinally, ctetreau. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: aaron.ballman. Herald added a project: clang. This pa