[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

2020-07-14 Thread Logan Smith via Phabricator via cfe-commits
logan-5 added a comment. In D83611#2151278 , @dblaikie wrote: > If you add/leave the "Differential Revision: https://reviews.llvm.org/D; > line in the commit message (arc will add this line automatically) Phabricator > will close the review for you

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

2020-07-14 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D83611#2151208 , @logan-5 wrote: > Committed as rG2c2a297bb6d1 > If you add/leave the "Differential Revision: https://reviews.llvm.org/D; line in

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

2020-07-14 Thread Logan Smith via Phabricator via cfe-commits
logan-5 closed this revision. logan-5 added a comment. Committed as rG2c2a297bb6d1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83611/new/ https://reviews.llvm.org/D83611

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

2020-07-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! (I can't actually find where the instructions are on how to request commit access these days - but should you find them, I thin it'd be fine for you to have commit

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

2020-07-10 Thread Logan Smith via Phabricator via cfe-commits
logan-5 created this revision. logan-5 added a project: clang. Herald added subscribers: cfe-commits, martong. This patch adds `override` to several overriding virtual functions that were missing the keyword within the clang/ directory. NFC. These were found by a Clang build equipped with