[PATCH] D83691: Port Comment option flags to new parsing system

2020-11-19 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1702a297b8b: [clang][cli] Port Comment option flags to new parsing system (authored by jansvoboda11). Changed prior to commit:

[PATCH] D83691: Port Comment option flags to new parsing system

2020-11-19 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Thanks. Committing this without the NFC change. Comment at: clang/include/clang/Driver/Options.td:407 + +def fparse_all_comments : Flag<["-"], "fparse-all-comments">, Group, Flags<[CC1Option]>, +

[PATCH] D83691: Port Comment option flags to new parsing system

2020-11-18 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM after you fix a couple of nits. Comment at: clang/include/clang/Driver/Options.td:405 +// Comment Options + Nit: please end the comment with

[PATCH] D83691: Port Comment option flags to new parsing system

2020-11-18 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. WDYT @Bigcheese? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D83691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83691: Port Comment option flags to new parsing system

2020-11-18 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 306042. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D83691 Files: clang/include/clang/Driver/Options.td

[PATCH] D83691: Port Comment option flags to new parsing system

2020-11-18 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/

[PATCH] D83691: Port Comment option flags to new parsing system

2020-07-13 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83690 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83691 Files: