This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2b84efa00040: [clang][cli] Port Frontend option flags to new
option parsing system (authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83697/new/
https://reviews.llvm.org/D83697
jansvoboda11 updated this revision to Diff 307045.
jansvoboda11 added a comment.
Drop namespace specifier & names of unused args, add tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83697/new/
https://reviews.llvm.org/D83697
Files:
clang/inc
dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.
This is close, just a few nits. Also, since this has the first uses of
`IsNegative`, it'd be great to have a couple of tests for one of the flags it's
used on.
===
