This revision was automatically updated to reflect the committed changes.
Closed by commit rG20157410862d: [ASTImporter] Refactor ASTImporter to support
custom downstream tests (authored by vabridgers, committed by einvbri
vince.a.bridg...@ericsson.com).
Repository:
rG LLVM Github Monorepo
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Ok, LGTM! Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83970/new/
https://reviews.llvm.org/D83970
balazske added a comment.
Future improvement: Split `ASTImporterTest.cpp` into smaller parts. It is still
too large.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83970/new/
https://reviews.llvm.org/D83970
vabridgers added a comment.
@shafik, Thanks! I'll wait 'til Gabor gets a chance to review before landing.
Best!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83970/new/
https://reviews.llvm.org/D83970
shafik added a comment.
LGTM but I want @martong to take a look as well and accept.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83970/new/
https://reviews.llvm.org/D83970
___
cfe-commits mailing
vabridgers created this revision.
vabridgers added a reviewer: martong.
Herald added subscribers: cfe-commits, teemperor, rnkovacs.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: clang.
The purpose of this change is to do a small refactoring of code
