[PATCH] D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5

2020-07-21 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thank you. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84221/new/ https://reviews.llvm.org/D84221 ___

[PATCH] D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5

2020-07-20 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam added a comment. Can you add test with version string 50 also? So, tests should be there for version 45, version 50, and default version. It will ensure that this test doesn't silently stops testing for 50 when we upgrade to the next version. Repository: rG LLVM Github Monorepo CHA

[PATCH] D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5

2020-07-20 Thread Pushpinder Singh via Phabricator via cfe-commits
pdhaliwal created this revision. pdhaliwal added reviewers: saiislam, ABataev, jdoerfert. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. This was missed when default version was upgraded to 5.0 (part of D81098 )