[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

This revision was automatically updated to reflect the committed changes. Closed by commit rG160ff83765ac: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3 (authored by saiislam). Changed prior to commit: https://reviews.llvm.org/D84260?vs=282010&id=282502#toc Reposi

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 ___ c

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 282010. saiislam added a comment. Changes as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGOpe

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.h:30-31 + + /// Declare AMDGCN specific specialization of functions which + /// have been generalized as virtual functions in CGOpenMPRuntimeGPU + These 2 lines can be removed, t

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 282002. saiislam added a comment. Improved comment placement. Corrected check lines. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeGe

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:201-205 /// Declare generalized virtual functions which need to be defined - /// by all specializations of OpenMPGPURuntime Targets. + /// by all specializations of OpenMPGPURuntime Targets lik

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 281932. saiislam added a comment. Moved comments to header files. Used regexps for test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeG

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:51 + +/// Get the maximum number of threads in a block of the GPU. +llvm::Value *CGOpenMPRuntimeAMDGCN::getGPUNumThreads(CodeGenFunction &CGF) { Move these comments to the head

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 280810. saiislam added a comment. Generalized regex in one of the test to pass harbormaster build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/C

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:129 + auto *Alloca = Var.getPointer(); + assert(isa(Alloca) || + (isa(Alloca) && @arsenm , it wasn't possible to post D78495 and this pat

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 280660. saiislam added a comment. Added InitTempAlloca address space cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeGen/CGExpr.cpp clan

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 279610. saiislam added a comment. Added final to specialized classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.h:25 -class CGOpenMPRuntimeNVPTX : public CGOpenMPRuntimeGPU { +class CGOpenMPRuntimeAMDGCN : public CGOpenMPRuntimeGPU { `final` Comment at: clang/lib/CodeG

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, JonChesterfield, grokos. Herald added subscribers: cfe-commits, aaron.ballman, sstefan1, guansong, yaxunl, mgorny, jvesely, jholewinski. Herald added a project: clang. Provides AMDGCN and NVPTX specific specialization o