[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-08-14 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; morehouse wrote: > morehouse wrote: > > vitalybuka

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-08-14 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; morehouse wrote: > vitalybuka wrote: > > morehouse

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-29 Thread Matt Morehouse via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2d0b44a7cd2: [DFSan] Add efficient fast16labels instrumentation mode. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-29 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; vitalybuka wrote: > morehouse wrote: > > vitalybuk

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-29 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse updated this revision to Diff 281687. morehouse marked 2 inline comments as done. morehouse added a comment. - Remove preinit stuff and API warnings; use custom union-load callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84371/new/

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-28 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM either way Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast1

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-24 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse updated this revision to Diff 280485. morehouse marked 5 inline comments as done. morehouse added a comment. - Rename flag - Clarify doc example - Use temporary variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84371/new/ https://r

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-24 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; vitalybuka wrote: > isn't better just create new s

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-23 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; isn't better just create new set of callbacks? e.

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-23 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc added a comment. Yep, cool. LGTM from me, but please get another pair if eyes (Vitaly?) Comment at: clang/docs/DataFlowSanitizer.rst:182 +less CPU and code size overhead. To use fast16labels instrumentation, you'll +need to specify `-fsanitize=dataflow -mllvm -fast-16-labe

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-23 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse updated this revision to Diff 280304. morehouse added a comment. - Fix libfuzzer dataflow tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84371/new/ https://reviews.llvm.org/D84371 Files: clang/docs/DataFlowSanitizer.rst compile

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-23 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added a subscriber: Dor1s. morehouse added a comment. In D84371#2168367 , @kcc wrote: > In what cases do we still call __dfsan_union? We still call `__dfsan_union_load` when we load sizes greater than 2 bytes but not divisible by 4. I actuall

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-23 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse updated this revision to Diff 280286. morehouse marked 6 inline comments as done. morehouse added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add documentation. - Remove fast16labels runtime flag. Repository: rG LLVM Github Monorepo CHANGES SI