[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG497d060d0a74: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske updated this revision to Diff 284588. balazske marked an inline comment as done. balazske added a comment. Rebase (bug category is LogicError). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84520/new/ https://reviews.llvm.org/D84520

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Also thanks, let's land! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84520/new/ https://reviews.llvm.org/D84520

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

NoQ added a comment. In D84520#2206077 , @balazske wrote: > Do the null pointer and invalid pointer dereference belong to the same > checker, that is called //NullDereference//? Yup. And that's bad. Note that the only reason to have checker names is to

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

whisperity added a comment. In D84520#2206077 , @balazske wrote: > Do the null pointer and invalid pointer dereference belong to the same > checker, that is called //NullDereference//? I think both SA and Tidy auto-appends the checker's name into the

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske marked an inline comment as done. balazske added a comment. Do the null pointer and invalid pointer dereference belong to the same checker, that is called //NullDereference//? Comment at: clang/test/Analysis/misc-ps-region-store.m:1160 struct list_pr8141 *items; -

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske updated this revision to Diff 284283. balazske added a comment. Preserve original error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84520/new/ https://reviews.llvm.org/D84520 Files:

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

NoQ added a comment. Thanks, excellent! Let's not change warning text without good reasons. Too few of us speak English well enough to check the articles. The original text seems concise and on-point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske updated this revision to Diff 283856. balazske added a comment. Herald added a subscriber: whisperity. NFC changes, added some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84520/new/ https://reviews.llvm.org/D84520 Files:

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

Szelethus added a comment. We definitely need more tests. The idea overall however is amazing, thanks! Comment at: clang/test/Analysis/misc-ps-region-store.m:1160 struct list_pr8141 *items; - for (;; items = ({ do { } while (0); items->tail; })) //

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

gamesh411 added a comment. I would add one more test for the undefined case. Like a local array variable that is uninitialized. That could mirror some of the null-dereference cases. Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:135 +DerefKindStr =

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske added a comment. Change of the existing error messages and checker category is not necessary but it would be improvement because more the uniform error messages. (And not the "logic error" is the best category for this checker, if this value is used at all. Other checkers have bad

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske marked an inline comment as done. balazske added a comment. Not sure if this is a good solution. There are few tests that test the undefined reference case. But the added code should work the same way as in the null pointer case? Comment at:

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Report