This revision was automatically updated to reflect the committed changes.
Closed by commit rG6ef801aa6bc0: [AIX] Static init frontend recovery and
backend support (authored by Xiangling_L).
Changed prior to commit:
https://reviews.llvm.org/D84534?vs=283712&id=284355#toc
Repository:
rG LLVM G
jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84534/new/
https://reviews.llvm.org/D84534
___
cfe-commits mailing list
cf
Xiangling_L updated this revision to Diff 283712.
Xiangling_L marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84534/new/
https://reviews.llvm.org/D84534
Files:
clang/lib/CodeGen/CGDeclCXX.cpp
clang/lib/CodeGen/CodeGenModule.h
clang/lib/CodeGen/Itaniu
Xiangling_L marked 3 inline comments as done.
Xiangling_L added inline comments.
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:466
+
+ bool preprocessStructorList(const DataLayout &DL, const Constant *List,
+ SmallVector &Structors);
---
jasonliu added inline comments.
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:466
+
+ bool preprocessStructorList(const DataLayout &DL, const Constant *List,
+ SmallVector &Structors);
Xiangling_L wrote:
> jasonliu wrote:
> > Xi
Xiangling_L marked 5 inline comments as done.
Xiangling_L added inline comments.
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:466
+
+ bool preprocessStructorList(const DataLayout &DL, const Constant *List,
+ SmallVector &Structors);
---
jasonliu added inline comments.
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:391
+ /// @param[out] Structors Sorted Structor structs by Priority.
+ /// @return false if List is not an array of '{ i32, void ()*, i8* }'
structs.
+ bool preprocessXXStructorList(const DataL
Xiangling_L updated this revision to Diff 283396.
Xiangling_L marked 2 inline comments as done.
Xiangling_L added a comment.
Added descriptions for struct and functions;
Addressed other comments;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84534/new/
https://reviews.llvm.org/D84534
F
Xiangling_L marked 7 inline comments as done.
Xiangling_L added inline comments.
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:466
+
+ bool preprocessStructorList(const DataLayout &DL, const Constant *List,
+ SmallVector &Structors);
---
jasonliu added inline comments.
Comment at: format:1
+//===-- PPCAsmPrinter.cpp - Print machine instrs to PowerPC assembly
--===//
+//
Redundant file?
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:455
}
+ struct Structor {
-
Xiangling_L added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1865
+if (isSpecialLLVMGlobalArrayForStaticInit(&G)) {
+ if (GlobalUniqueModuleId.empty()) {
+GlobalUniqueModuleId = getUniqueModuleId(&M);
jasonliu wrote:
>
Xiangling_L marked 6 inline comments as done.
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.h:1058
+ /// Add an sterm finalizer to its own llvm.global_dtors entry.
+ void AddCXXStermFinalizerToGlobalDtor(llvm::Function *StermFinalizer,
+
jasonliu added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1865
+if (isSpecialLLVMGlobalArrayForStaticInit(&G)) {
+ if (GlobalUniqueModuleId.empty()) {
+GlobalUniqueModuleId = getUniqueModuleId(&M);
We will need to move
jasonliu added inline comments.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:24
#include "llvm/Support/Path.h"
#include "llvm/Transforms/Utils/ModuleUtils.h"
We are removing the usage of "getUniqueModuleId" in this file, So I assume this
include could get rem
Xiangling_L updated this revision to Diff 281938.
Xiangling_L added a comment.
Removed the disablement in IncrementalProcessingTest.cpp cross-target test;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84534/new/
https://reviews.llvm.org/D84534
Files:
clang/lib/CodeGen/CGDeclCXX.cpp
Xiangling_L updated this revision to Diff 281240.
Xiangling_L marked 4 inline comments as done.
Xiangling_L added a comment.
Created alias for sinit and sterm;
Adjusted the testcase accordingly;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84534/new/
https://reviews.llvm.org/D84534
Fi
Xiangling_L marked 5 inline comments as done.
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4609
+// their own llvm.global_dtors entry.
+CGM.AddCXXStermFinalizerToGlobalDtor(StermFinalizer, 65535);
+ else
jasonliu wro
jasonliu added inline comments.
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4609
+// their own llvm.global_dtors entry.
+CGM.AddCXXStermFinalizerToGlobalDtor(StermFinalizer, 65535);
+ else
Handling template instantiation seems fairly orthogonal to "m
Xiangling_L updated this revision to Diff 280897.
Xiangling_L added a comment.
Fix clang-tidy errors;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84534/new/
https://reviews.llvm.org/D84534
Files:
clang/lib/CodeGen/CGDeclCXX.cpp
clang/lib/CodeGen/CodeGenModule.h
clang/lib/CodeGe
Xiangling_L created this revision.
Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, yusra.syeda,
zarko, xingxue.
Xiangling_L added a project: LLVM.
Herald added subscribers: llvm-commits, cfe-commits, jfb, kbarton, hiraditya,
nemanjai.
Herald added a project: clang.
1. Frontend sid
20 matches
Mail list logo