eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:788-789
-
-// Remove "::" from the `SourceRange`
-SR.setEnd(SR.getEnd().getLocWithOffset(-1));
Newbie mistake causing the crash
Comment at: clang/lib
eduucaldas updated this revision to Diff 283876.
eduucaldas added a comment.
Remove Fix crash on name specifier commit from patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84781/new/
https://reviews.llvm.org/D84781
Files:
clang/include/clang
gribozavr2 added a comment.
Seeing the API, I like the inheritance-based approach better. It seems more
uniform.
Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:219
+ syntax::EmptyNode *, syntax::Leaf *, syntax::DecltypeSpecifier *,
+ syntax::SimpleTemplateSpecifier *
