[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf71deb43abea: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors. (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D84870?vs=281722&id=281785#toc Repository:

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D84870#2183096 , @akhuang wrote: > remove change to add class types to retained types list, > > also fix the test case to be a struct that previo

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 281722. akhuang added a comment. remove change to add class types to retained types list, also fix the test case to be a struct that previously didn't get complete debug info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. In D84870#2182463 , @dblaikie wrote: > I think it'd be good to separate these two issues/patches. > > In part because I'm curious whether, even with a trivial ctor - if we did the > retained types thing - would that be enough? I

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. I think it'd be good to separate these two issues/patches. In part because I'm curious whether, even with a trivial ctor - if we did the retained types thing - would that be enough? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via Phabricator via cfe-commits
akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. akhuang requested review of this revision. Previously ctor homing was omitting debug info for classes if they have both trival and nontrivial constructo