[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabbe9e227ed3: [clang-tidy] Added command line option `fix-notes` (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 __

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:186 - // Emit a fix and a fix description of the check; - diag(Context.FoundUsingDecl->getLocation(), - /*Description=*/"remove the using", DiagnosticIDs::N

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 updated this revision to Diff 326779. njames93 marked 6 inline comments as done. njames93 added a comment. Rebased and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 Files: clan

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:231 +/// If \p AnyFix is true and there is no FixIt attached to the Message, +/// returns the first FixIt attached to any notes in the message. +/// If no FixIt is found, r

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 updated this revision to Diff 313272. njames93 added a comment. Only apply fixes from notes if there is exactly one fix found in them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 Files: clang

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 added a comment. In D84924#2466564 , @aaron.ballman wrote: > Agreed, but I don't think the current behavior in this patch is cautious > enough. I like that we have to specify "please apply fixits from notes" > explicitly. I think that's the rig

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

aaron.ballman added a comment. In D84924#2465745 , @njames93 wrote: > In D84924#2446075 , @aaron.ballman > wrote: > >> In D84924#2184132 , @njames93 wrote: >> >>> This is ve

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 added a comment. In D84924#2446075 , @aaron.ballman wrote: > In D84924#2184132 , @njames93 wrote: > >> This is very much a work in progress >> Another direction I was thinking was only apply the fixes foun

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, gribozavr2, Eugene.Zelenko, hokein. Herald added subscribers: cfe-commits, arphaman, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Added an option to control whether to apply t