This revision was automatically updated to reflect the committed changes.
Closed by commit rG1af037f643fc: [PowerPC] Correct cpsgns behaviour on
PowerPC to match that of the ABI (authored by Conanap).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84962/new/
https://reviews.llvm.org/D84962
___
cfe-commits mailing list
Conanap marked 3 inline comments as done.
Conanap added a comment.
Addressed Nemenja's concerns.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84962/new/
https://reviews.llvm.org/D84962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Conanap updated this revision to Diff 297936.
Conanap added a comment.
Use regex match to check for variable order in IR instead.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84962/new/
https://reviews.llvm.org/D84962
Files:
clang/lib/Headers/altivec.h
nemanjai added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1
-// REQUIRES: powerpc-registered-target
+// requires: powerpc-registered-target
// RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx -triple
powerpc64-unknown-unknown -emit-llvm %s
bsaleil accepted this revision.
bsaleil added a comment.
LGTM, please fix the unrelated change when committing.
Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1
-// REQUIRES: powerpc-registered-target
+// requires: powerpc-registered-target
// RUN: %clang_cc1
Conanap updated this revision to Diff 294778.
Conanap marked an inline comment as done.
Conanap added a comment.
Changed the location of fix and added extra test cases
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84962/new/
https://reviews.llvm.org/D84962
Files:
nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.
This is not what we want. The builtin behaves correctly. It is equivalent to
the generic `__builtin_copysign` and it would be very surprising to a user if
it reverses the
bsaleil added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1840
+// CHECK: %6 = call <4 x float> @llvm.copysign.v4f32(<4 x float> %5, <4 x
float> %4)
+ vec_cpsgn(a, b);
+}
Could you also add a call to `__builtin_vsx_xvcpsgnsp` and the
Conanap updated this revision to Diff 292589.
Conanap added a comment.
Herald added a subscriber: kbarton.
Added extra test case to demonstrate that the arguments will be reversed
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84962/new/
https://reviews.llvm.org/D84962
Files:
nemanjai added a comment.
Yes, this definitely needs a test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84962/new/
https://reviews.llvm.org/D84962
___
cfe-commits mailing list
bsaleil added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14298
llvm::Function *F = CGM.getIntrinsic(ID, ResultType);
-return Builder.CreateCall(F, {X, Y});
+return Builder.CreateCall(F, {Y, X});
}
Could you add a test case in
Conanap created this revision.
Conanap added reviewers: PowerPC, saghir, nemanjai, hfinkel.
Conanap added projects: LLVM, clang, PowerPC.
Herald added subscribers: cfe-commits, shchenz.
Conanap requested review of this revision.
Repository:
rG LLVM Github Monorepo
13 matches
Mail list logo
