[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

hokein created this revision. Herald added subscribers: cfe-commits, dang, arphaman, kbarton, nemanjai. Herald added a project: clang. hokein requested review of this revision. Herald added a subscriber: wuzish. This is a large patch containing all required changes, want early feedback. what does

[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

rsmith added a comment. Looks reasonable to me. I expect you'll find more places that need to learn how to handle dependent types in C, but this looks like a solid start. Comment at: clang/lib/AST/Expr.cpp:3757-3758 case NPC_ValueDependentIsNull: - if (isTypeDependen

[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

hokein added a comment. In D85025#2201042 , @rsmith wrote: > Looks reasonable to me. I expect you'll find more places that need to learn > how to handle dependent types in C, but this looks like a solid start. Thanks! Yeah, we'd need to a detailed plan t

[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

hokein abandoned this revision. hokein added a comment. Herald added a subscriber: dexonsmith. Thanks for @rsmith's initial comments. This is done, all related patches have been landed in upstream, and this feature is enabled by default for all languages. Repository: rG LLVM Github Monorepo