[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu updated this revision to Diff 324695. zequanwu added a comment. Tested on clange stage2 build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm.org/D85176 Files: clang/lib/CodeGen/CoverageMappingGen.cpp cl

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu added a comment. In D85176#2241257 , @phosek wrote: > We started seeing assertion failure after rolling a toolchain that contains > this change and `git bisect` identified this change. I have filed a bug with > a reproducer as PR47324. It has b

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

phosek added a comment. We started seeing assertion failure after rolling a toolchain that contains this change and `git bisect` identified this change. I have filed a bug with a reproducer as PR47324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu reopened this revision. zequanwu added a comment. This revision is now accepted and ready to land. Here is a repro of crash caused by this change. int k, l; #define m(e) e##e void p() { int kk,ll; if (k) m(k); else l = m(l); } `SM.getExpansLoc(AfterLoc)`

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa31c89c1b7a0: [Coverage] Enable emitting gap area between macros (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, looks good to me! Please check for any issues in a stage2 coverage build before landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu updated this revision to Diff 284858. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm.org/D85176 Files: clang/lib/CodeGen/CoverageMappingGen.cpp clang/test/Cove

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

vsk added inline comments. Comment at: clang/test/CoverageMapping/macro-expressions.cpp:63 // CHECK-NEXT: File 0, [[@LINE+1]]:16 -> [[@LINE+1]]:18 = #2 if (EXPR(i)) {} // CHECK-NEXT: Expansion,File 0, [[@LINE+2]]:9 -> [[@LINE+2]]:14 = (#0 + #3) The gap r

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. Bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45849 This is caused by gap area not emitted if either `AfterLoc` or `BeforeLoc` is a macro loca