[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

This revision was automatically updated to reflect the committed changes. Closed by commit rG626d0f5818b2: [Concepts] Dump template arguments for immediately declared constraint. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D852

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Ok, sounds reasonable to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85282/new/ https://reviews.llvm.org/D85282 _

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

hokein added a comment. In D85282#2198737 , @nridge wrote: > This patch has helped me understand the difference between the two > `ConceptReference`s in the AST (the `TypeConstraint` and the > `ConceptSpecializationExpr`). > > Given that > > `template R

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

hokein updated this revision to Diff 283841. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85282/new/ https://reviews.llvm.org/D85282 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/lib/A

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:18 // CHECK: TemplateTypeParmDecl {{.*}} referenced Concept {{.*}} 'binary_concept' - // CHECK-NEXT: |-ConceptSpecializationExpr {{.*}} 'bool' Concept {{.*}} 'binary_concept' - // CHECK-NE

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge added a comment. This patch has helped me understand the difference between the two `ConceptReference`s in the AST (the `TypeConstraint` and the `ConceptSpecializationExpr`). Given that `template R>` is a shorthand for `template requires binary_concept` the `TypeConstraint` is the

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

hokein created this revision. hokein added a reviewer: nridge. Herald added a subscriber: kristof.beyls. Herald added a project: clang. hokein requested review of this revision. The template arguments were dumped as part of the TemplateTypeParmDecl, which was incorrect. Repository: rG LLVM Git