This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd39a9e3b4d4a: [Driver] Support GNU ld on Solaris (authored
by ro).
Changed prior to commit:
https://reviews.llvm.org/D85309?vs=554946&id=555463#to
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:55
+ StringRef UseLinker = A ? A->getValue() : CLANG_DEFAULT_LINKER;
+ // FIXME: What about -fuse-ld=?
+ return
ro added inline comments.
Comment at: clang/test/Driver/hip-link-bundle-archive.hip:59
// RUN: %clang -### --offload-arch=gfx906 --offload-arch=gfx1030 \
-// RUN: --target=x86_64-pc-windows-msvc \
+// RUN: --target=x86_64-pc-windows-msvc -fuse-ld= \
// RUN: -nogpuinc -nog
MaskRay added inline comments.
Comment at: clang/test/Driver/hip-link-bundle-archive.hip:59
// RUN: %clang -### --offload-arch=gfx906 --offload-arch=gfx1030 \
-// RUN: --target=x86_64-pc-windows-msvc \
+// RUN: --target=x86_64-pc-windows-msvc -fuse-ld= \
// RUN: -nogpuinc
ro updated this revision to Diff 554946.
ro marked an inline comment as done.
ro added a comment.
Move `isLinkerGnuLd` to `Solaris.{h,cpp}` and into `solaris` namespace to make
it unambigously clear where to use it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revi
ro marked an inline comment as done.
ro added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:305
+bool tools::isLinkerGnuLd(const ToolChain &TC, const ArgList &Args) {
+ // Only used if targetting Solaris.
MaskRay wrote:
> I suppose th
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:305
+bool tools::isLinkerGnuLd(const ToolChain &TC, const ArgList &Args) {
+ // Only used if targetting Solaris.
I suppose that this should be in a Solaris specific file to i
ro updated this revision to Diff 554711.
ro retitled this revision from "[WIP][clang][Driver] Support GNU ld on Solaris"
to "[Driver] Support GNU ld on Solaris".
ro added a comment.
Herald added subscribers: llvm-commits, Sanitizers, Enna1, ormris.
Herald added a reviewer: sscalpone.
Herald added
