[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3ac30188666: [clangd] Disable define out-of-line code action on templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85310/new/

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:393 +if (auto *PT = Source->getDescribedFunctionTemplate()) { + if (PT->getTemplatedDecl() == Source) +return false;

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet updated this revision to Diff 283266. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85310/new/ https://reviews.llvm.org/D85310 Files: clang-tools-ex

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:125 "Couldn't get range for function."); // Include template parameter list. if (auto *FTD = FD->getDescribedFunctionTemplate())

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo