This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc655d8081570: [SyntaxTree] Extend the syntax tree dump to
also cover `NodeRole` (authored by eduucaldas).
Changed prior to commit:
eduucaldas updated this revision to Diff 287563.
eduucaldas added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85330/new/
https://reviews.llvm.org/D85330
Files:
clang/include/clang/Tooling/Syntax/Tree.h
eduucaldas updated this revision to Diff 287562.
eduucaldas added a comment.
reorganize and nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85330/new/
https://reviews.llvm.org/D85330
Files:
clang/include/clang/Tooling/Syntax/Tree.h
eduucaldas updated this revision to Diff 287431.
eduucaldas marked 4 inline comments as done.
eduucaldas added a comment.
- Nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85330/new/
https://reviews.llvm.org/D85330
Files:
eduucaldas updated this revision to Diff 287430.
eduucaldas marked an inline comment as done.
eduucaldas added a comment.
Update tests to dump role
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85330/new/
https://reviews.llvm.org/D85330
Files:
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:107-110
int main() {
if (1) {}
if (1) {} else if (0) {}
}
eduucaldas wrote:
> I just noticed that we didn't yet use annotations on statement tests.
> I think
gribozavr2 added a comment.
Output format LGTM!
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:160
+ assert(N);
+ if (auto *L = llvm::dyn_cast(N)) {
+OS << "'";
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:169
- auto *T = cast(N);
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:158
if (!Marks.empty())
OS << Marks << ": ";
gribozavr2 wrote:
> Maybe the marks should be moved after the primary identifier of the node,
> WDYT? That would be more
eduucaldas updated this revision to Diff 286983.
eduucaldas added a comment.
Adapt Statement tests to new testing infrastructure
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85330/new/
https://reviews.llvm.org/D85330
Files:
eduucaldas updated this revision to Diff 283506.
eduucaldas added a comment.
Answer comment.
Please suggest more descriptive markers.
Options I thought of:
`I` -> `unmodifiable`
`M` -> `not backed by source code` / `synthesized`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
gribozavr2 added inline comments.
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:158
if (!Marks.empty())
OS << Marks << ": ";
Maybe the marks should be moved after the primary identifier of the node, WDYT?
That would be more consistent with AST dump:
eduucaldas updated this revision to Diff 283305.
eduucaldas added a comment.
Rollback strOfLeaf
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85330/new/
https://reviews.llvm.org/D85330
Files:
clang/include/clang/Tooling/Syntax/Tree.h
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
Functional changes in the dump:
- Surround Leaf tokens with `'`
- Append `Node` dumps with `NodeRole` information, except for unknown roles
13 matches
Mail list logo
