This revision was automatically updated to reflect the committed changes.
Closed by commit rG909a851dbffe: [CGAtomic] Mark atomic libcall functions
`nounwind` (authored by guiand).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85573/new/
https://rev
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85573/new/
https://reviews.llvm.org/D85573
___
guiand updated this revision to Diff 284922.
guiand added a comment.
Added `willreturn`. I think `nocapture` is probably best left to a future
change since it's more invasive -- it would require keeping tabs of which
arguments to each function is a pointer arg.
Repository:
rG LLVM Github Mon
guiand added a comment.
I don't think we can necessarily guarantee `argmemonly/readonly/writeonly`,
particularly since these library calls can take a lock somewhere inside. I'll
definitely add `nocapture` and `willreturn` though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
eugenis added a comment.
nocapture on the pointer argument
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85573/new/
https://reviews.llvm.org/D85573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
eugenis added a comment.
While we are here, how about setting a few more attributes?
argmemonly, readonly/writeonly, willreturn come to mind.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85573/new/
https://reviews.llvm.org/D85573
guiand created this revision.
guiand added reviewers: rsmith, eugenis.
Herald added subscribers: cfe-commits, jfb.
Herald added a project: clang.
guiand requested review of this revision.
These functions won't ever unwind. This is useful for MemorySanitizer
as it simplifies handling __atomic_l
