[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the review. I've commit in 819ff6b945816dce144c8be577a3c245f702b59c Comment at:

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the delay, good guess as to what was happening :-) Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:88 + static bool hasCorrectValue(const

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman added a comment. In D85611#2230481 , @aaron.ballman wrote: > In D85611#2218144 , @aaron.ballman > wrote: > >> Ping > > Ping x2 I realize it's performance review time for some folks and their

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman added a comment. In D85611#2218144 , @aaron.ballman wrote: > Ping Ping x2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85611/new/ https://reviews.llvm.org/D85611 ___ cfe-commits

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85611/new/ https://reviews.llvm.org/D85611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman created this revision. aaron.ballman added reviewers: steveire, sbenza, klimek, sammccall. aaron.ballman requested review of this revision. Currently, when marshaling a dynamic AST matchers, we check for the type and value validity of matcher arguments at the same time for some