This revision was automatically updated to reflect the committed changes.
Closed by commit rGfdfe324da195: [clang-tidy] IncludeInserter: allow <>
in header name (authored by alexfh).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85666/new/
https://r
alexfh updated this revision to Diff 294678.
alexfh added a comment.
- Updated release notes and default option values in docs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85666/new/
https://reviews.llvm.org/D85666
Files:
clang-tools-extra/clan
alexfh updated this revision to Diff 294666.
alexfh marked 4 inline comments as done.
alexfh added a comment.
- clang-format
- addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85666/new/
https://reviews.llvm.org/D85666
Files
alexfh added inline comments.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:31
utils::IncludeSorter::IS_LLVM)),
- MathHeader(Options.get("MathHeader", "math.h")) {}
+ MathHeader(Options
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/IncludeInserter.cpp:98-103
+ assert(SourceMgr && "SourceMgr shouldn't be null; did you remember to call "
+ "registerPreprocessor()?");
+ bool IsAngled = Header.consume_front("<"
njames93 added a comment.
Should a line be added to the release notes to explain this behaviour:
'Checks that specify files to include now support wrapping the include in angle
brackets to create a system include'?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:31
utils::IncludeSorter::IS_LLVM)),
-
alexfh created this revision.
alexfh added reviewers: aaron.ballman, hokein.
Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai.
Herald added a project: clang.
alexfh requested review of this revision.
Herald added a subscriber: wuzish.
This adds a pair of overloads for
