[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

teemperor added a comment. I reverted in adf0b8cc70325f027d202139e3ff984c41896b57 to get the bots green again . Feel free to ping if you need someone to test the patch on macOS. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

teemperor added a comment. This broke Green Dragon's compiler-rt builds and also my local compiler-rt build. See for example here: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/23424/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd58fd4e52197: [compiler-rt] Compile assembly files as ASM not C (authored by phosek). Repository: rG LLVM Github Monore

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85706/new/ https://reviews.llvm.org/D85706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre added a comment. In D85706#2214009 , @phosek wrote: > One concern I have with this change is that we may not always consistently > update CMAKE_ASM_FLAGS or set CMAKE_ASM_COMPILER. This wouldn't make a > difference before, but it'll with this chan

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre updated this revision to Diff 285692. tambre added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pass CMAKE_ASM_COMPILER to compiler-rt in runtime build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85706/n