[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae7f08812e09: [InstCombine] Aggregate reconstruction simplification (PR47060) (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

lebedev.ri updated this revision to Diff 285898. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Patch updated - addressed all nits other than the question about decoupling `enum` values from variable names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

lebedev.ri added a comment. @spatel thank you for taking a look! In D85787#2220343 , @spatel wrote: > This seems similar in spirit to the recursive element tracking that we do in > collectShuffleElements() in this file or foldIdentityShuffles() in > Ins

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. This seems similar in spirit to the recursive element tracking that we do in collectShuffleElements() in this file or foldIdentityShuffles() in InstSimplify, but a bit more complicated (becaus

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

lebedev.ri added a comment. @spatel thank you for taking a look! In D85787#2216518 , @spatel wrote: > In D85787#2214038 , @lebedev.ri > wrote: > >> @ reviewers - i'm not so much interested in deep code/algo review

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

spatel added a comment. In D85787#2214038 , @lebedev.ri wrote: > @ reviewers - i'm not so much interested in deep code/algo review, > but more like in the general direction disscussion, like, is this okay for > instcombine? :) The test diffs look great,

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

lebedev.ri updated this revision to Diff 285371. lebedev.ri added a comment. Drop unneeded header include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85787/new/ https://reviews.llvm.org/D85787 Files: clang/test/CodeGenCXX/nrvo.cpp llvm/lib/

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

lebedev.ri updated this revision to Diff 285283. lebedev.ri added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix (overstepping) clang test being affected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm