This revision was automatically updated to reflect the committed changes.
Closed by commit rG55208f5a2126: [analyzer] Add modeling for unque_ptr::get()
(authored by vrnithinkumar).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86029/new/
NoQ accepted this revision.
NoQ added a comment.
This patch looks correct to me at a glance. I think we should land it as is and
debug/improve later.
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:362-363
+ const auto *InnerPointVal =
vrnithinkumar marked 2 inline comments as done.
vrnithinkumar added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:362-363
+ const auto *InnerPointVal = State->get(ThisRegion);
+ if (!InnerPointVal)
+return;
+
xazax.hun
vrnithinkumar updated this revision to Diff 286675.
vrnithinkumar edited the summary of this revision.
vrnithinkumar added a comment.
- Using conjureSymbolVal in case of missing inner pointer value
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
xazax.hun accepted this revision.
xazax.hun added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:362-363
+ const auto *InnerPointVal = State->get(ThisRegion);
+ if (!InnerPointVal)
+return;
+
NoQ wrote:
> You'll have to
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Excellent, thanks!
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:362-363
+ const auto *InnerPointVal = State->get(ThisRegion);
+ if (!InnerPointVal)
+
vrnithinkumar created this revision.
Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong,
Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet,
baloghadamsoftware, xazax.hun.
Herald added a project: clang.
vrnithinkumar requested review of this
