[PATCH] D86105: [darwin] Disable the -Wpsabi warning

2020-11-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2561-2565 // The "avx" feature changes how vectors >128 in size are passed. "avx512f" // additionally changes how vectors >256 in size are passed. Lik

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

2020-11-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 302977. arphaman added a comment. Address Ahmed's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86105/new/ https://reviews.llvm.org/D86105 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/target-avx-abi-diag.c clang/test/

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

2020-09-01 Thread Ahmed Bougacha via Phabricator via cfe-commits
ab added a comment. Hmm, is there a more general way to disable warnings? I'm not familiar with these parts, so I'll defer to you folks =] Comment at: clang/lib/CodeGen/TargetInfo.cpp:2515-2516 + if (!CallerHasFeat && !CalleeHasFeat) { +// Darwin doesn't enable AVX/AVX51

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

2020-08-17 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 286181. arphaman added a comment. add missing test fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86105/new/ https://reviews.llvm.org/D86105 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/target-avx-abi-diag.c clang/test/CodeG

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

2020-08-17 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ab, t.p.northover, erichkeane. Herald added subscribers: ributzka, dexonsmith, jkorous. arphaman requested review of this revision. The Darwin targets don't enable AVX/AVX512 by default to support Rosetta 2, so the new -Wpsabi warning adds