[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

2020-08-22 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe7d9182a666a: Enable constexpr on BITREVERSE builtin intrinsics (PR47249) (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D86339?vs=286999&id=287182#toc Repository: rG LLVM G

[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

2020-08-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Can you also add documentation to LanguageExtensions.rst? Thanks! Comment at: clang/docs/ReleaseNotes.rst:61 + ``__builtin_bitreverse32`` and ``__builtin_bitreverse64`` may now be used + within constexpr expressions. There's no such

[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

2020-08-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86339/new/ https://reviews.llvm.org/D86339 __

[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

2020-08-21 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon created this revision. RKSimon added reviewers: rsmith, craig.topper, spatel. Herald added a project: clang. RKSimon requested review of this revision. This enables us to use the __builtin_bitreverse 8/16/32/64 intrinsics inside constexpr code. Repository: rG LLVM Github Monorepo htt