pengfei added a comment.
Reverse ping. Any progress or plan for this patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86855/new/
https://reviews.llvm.org/D86855
___
cfe-commits mailing list
jyknight added a comment.
Ping, thanks!
Or, if you have suggestions on how to make it easier to review, I'd be open to
that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86855/new/
https://reviews.llvm.org/D86855
jyknight added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86855/new/
https://reviews.llvm.org/D86855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
craig.topper added inline comments.
Comment at: clang/lib/Headers/mmintrin.h:1264
{
-return (__m64)__builtin_ia32_pcmpgtw((__v4hi)__m1, (__v4hi)__m2);
+return (__m64)((__v4hi)__m1 > (__v4hi)__m2);
}
jyknight wrote:
> craig.topper wrote:
> > Same here
>
jyknight marked 7 inline comments as done.
jyknight added a comment.
Herald added a subscriber: pengfei.
I've finally got back to moving this patch forward -- PTAL, thanks!
To start with, I wrote a simple test-suite to verify the functionality of these
changes. I've included the tests I wrote
craig.topper added inline comments.
Comment at: clang/lib/Headers/mmintrin.h:367
{
-return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
+return (__m64)(((__v8qi)__m1) + ((__v8qi)__m2));
}
I think you we should use __v8qu to match what we do
jyknight created this revision.
jyknight added reviewers: craig.topper, spatel, RKSimon.
Herald added subscribers: cfe-commits, danielkiss.
Herald added a project: clang.
jyknight requested review of this revision.
Preliminary patch, posted to go along with discussion on llvm-dev.
3DNow!
