[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbd45b2db8e0: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl` (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

baloghadamsoftware updated this revision to Diff 292170. baloghadamsoftware added a comment. Checker `modernize-use-equals-delete` adjusted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87527/new/ https://reviews.llvm.org/D87527 Files: clang-tools-extra/clang-tidy/modernize/UseEqual

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

ymandel accepted this revision. ymandel added a comment. Thanks, this looks great! But, can you also please update https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clang-tidy/modernize/UseEqualsDeleteCheck.cpp#L39, since it depends on the current semantics? CHANGES SINCE LAS

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

baloghadamsoftware updated this revision to Diff 291901. baloghadamsoftware added a comment. Created another matcher `hasAnyBody`, and updated the documentation of the matchers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87527/new/ https://reviews.llvm.org/D87527 Files: clang/inc

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

ymandel added a comment. In D87527#2271059 , @baloghadamsoftware wrote: > We must decide about the namings. If we want to be in sync with the methods > in `FunctionDecl`, then we keep `hasBody()` as is, but remove the template > specialization, and crea

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

baloghadamsoftware added a comment. > Thank you for clarifying. I might nitpick that it's not "obviously wrong": > I'm actually writing code now that depends on exactly that behavior -- I > don't care where the method decl body is, as long as it's visible in the > current TU. That said, I thin

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

ymandel added a comment. In D87527#2271016 , @baloghadamsoftware wrote: > In D87527#2270939 , @ymandel wrote: > >> Can you expand on what is wrong currently for `FunctionDecl` descendants? >> Would the new test `F

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

baloghadamsoftware added a comment. In D87527#2270939 , @ymandel wrote: > Can you expand on what is wrong currently for `FunctionDecl` descendants? > Would the new test `FindsBodyOfFunctionChildren` fail with the current > implementation? Yes, exactly.

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

ymandel added a comment. Can you expand on what is wrong currently for `FunctionDecl` descendants? Would the new test `FindsBodyOfFunctionChildren` fail with the current implementation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87527/new/ http

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. > Unfortunately template specializations do not catch the descendants of the > class for which the template is specialized. Therefore it does not work > correcly for the descendants of Funct

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

lebedev.ri added a comment. Thank you for looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87527/new/ https://reviews.llvm.org/D87527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

baloghadamsoftware added a comment. In D87527#2268348 , @whisperity wrote: > What about http://clang.llvm.org/doxygen/classclang_1_1CXXConversionDecl.html > ? That is part of "etc.". It works for all current and future descendants of `FunctionDecl` now.

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

whisperity added a comment. What about http://clang.llvm.org/doxygen/classclang_1_1CXXConversionDecl.html ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87527/new/ https://reviews.llvm.org/D87527 ___ cf

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: klimek, sbenza. baloghadamsoftware added a project: clang. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs. baloghadamsoftware requested review of this revision. //AST Matcher// `hasBody` is a p