[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman closed this revision. aaron.ballman added a comment. In D87962#2313363 , @nomanous wrote: > In D87962#2312617 , @aaron.ballman > wrote: > >> LGTM! Do you need someone to commit on your behalf? > > Yes

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. In D87962#2312617 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes I need! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___ cfe-commits mailing list cfe

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 296118. nomanous added a comment. In this revision I delete the useless main function in the new test case and rename ext_multichar_character_literal & ext_four_char_character_literal to warn_multichar_character_literal & warn_four_char_character_literal.

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:109 "multi-character character constant">, InGroup; -def ext_four_char_character_literal : Extension< +def ext_four_char_character_literal : Warning< "multi-character character constan

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D87962#2307824 , @rsmith wrote: > In D87962#2306043 , @aaron.ballman > wrote: > >> That doesn

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 295771. nomanous added a comment. I restore some needless modification in the previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 295766. nomanous added a comment. I change the four-char constants back to "Warning" in this revision, but set it to be ignored by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 Files: clang/in

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

rsmith added a comment. In D87962#2306043 , @aaron.ballman wrote: > That doesn't sound like the right approach to me -- Remarks are usually for > reporting backend decision-making to the frontend for things like > optimization passes. To be clear: that

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D87962#2305375 , @nomanous wrote: > In D87962#2298021 , @aaron.ballman > wrote: > >

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

efriedma added a comment. > Or should we change the four character case to "Remark" so it wouldn't be > warned even with the "-pandemic" option? There seems no other choice. There's a DefaultIgnore modifier for warnings that turns then off by default. We use this sparingly, since it's hard to

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 295559. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/test/CXX/lex/lex.literal/lex.ccon/p1.cpp clang/test/FixIt/format.m clang/test/Lexer

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. In D87962#2298021 , @aaron.ballman wrote: > Multichar literals are implementation-defined in C and conditionally > supported with implementation-defined semantics in C++. I agree that it may > make sense to warn about their use

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman added a comment. Multichar literals are implementation-defined in C and conditionally supported with implementation-defined semantics in C++. I agree that it may make sense to warn about their use for portability reasons, but I'm not certain whether it makes sense to promote their

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. Ping @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous created this revision. nomanous added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. nomanous requested review of this revision. The multi-character character constants should be implementation-defined according to the C standard but actually w