[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

2020-09-26 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D88005#2296254 , @dmajor wrote: > This change broke the configure step of Firefox mingw builds. > > The build bot won't give me the full details, so I'll need to set up a local > repro next week if needed, but my hunch is that

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

2020-09-25 Thread dmajor via Phabricator via cfe-commits
dmajor added a comment. This change broke the configure step of Firefox mingw builds. The build bot won't give me the full details, so I'll need to set up a local repro next week if needed, but my hunch is that we have some test like `$CC $CFLAGS conftest.c -o conftest` and then check for the e

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

2020-09-21 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGead7c3cdc34c: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8800

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

2020-09-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88005/new/ https://reviews.llvm.org/D88005 ___ cfe-com

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

2020-09-21 Thread Mateusz Mikuła via Phabricator via cfe-commits
mati865 added a comment. LGTM Confirmed that GCC 9 still adds `.exe`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88005/new/ https://reviews.llvm.org/D88005 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

2020-09-21 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: rnk, amccarth. Herald added a project: clang. mstorsjo requested review of this revision. GCC 8 changed behaviour wrt this, and made it consistent for cross compilation cases. While it's a change, it's a more sensible behaviour going forwa