[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. In D88314#2322870 , @bogser01 wrote: > @aaron.ballman Thank you for picking up this review! Running the check over > the entire LLVM causes ~74K warnings across 430 files. As to the false > positive rate it's tricky to

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 297355. bogser01 added a comment. Rebase diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D88314: Added llvm-string-referencing check

bogser01 added a comment. @aaron.ballman Thank you for picking up this review! Running the check over the entire LLVM causes ~74K warnings across 430 files. As to the false positive rate it's tricky to measure. Based on previous analysis on //flang// codebase, I would say roughly 50% of the

[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. It looks like you generated a diff from a previous diff instead of trunk -- can you regenerate the diff against trunk so that reviewers can see the full content of the changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 297246. bogser01 added a comment. Added documentation & Nit fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files:

[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. Thank you for working on this check! Have you run the check over LLVM to see how much it reports? One of the concerns I have with this is that it's not always appropriate to replace a `const std::string&` with an `llvm::StringRef` and so I'm wondering what the

[PATCH] D88314: Added llvm-string-referencing check

bogser01 added a comment. @alexfh does this look alright? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295811. bogser01 added a comment. Remove conflict markers 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295810. bogser01 added a comment. Removed residual conflict markers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files:

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295580. bogser01 added a comment. Fixed unit test 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295553. bogser01 added a comment. Fixed failing unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D88314: Added llvm-string-referencing check

bogser01 created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. bogser01 requested review of this revision. Clang-tidy pass detecting the use of const std::string& references. Use of llvm::StringRef is recommended in the LLVM Programmer's Manual