This revision was automatically updated to reflect the committed changes.
Closed by commit rG4fb303f340e2: [clangd] Improve PopulateSwitch tweak to work
on non-empty switches (authored by tdeo, committed by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall accepted this revision.
sammccall added a comment.
Thank you!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88434/new/
https://reviews.llvm.org/D88434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tdeo marked 10 inline comments as done.
tdeo added a comment.
Thanks for the review! Please land this if there are no more issues.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88434/new/
https://reviews.llvm.org/D88434
___
cfe-commits
tdeo updated this revision to Diff 294959.
tdeo added a comment.
- Improve comments
- In apply(), assert on the conditions we established in prepare() instead of
proceeding.
- Remove redundant tests and add new ones for value-dependent and GNU range
cases.
CHANGES SINCE LAST ACTION
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Very nice, thank you!
A few nits about comments and asserts.
Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:112
- // If there aren't any
tdeo created this revision.
tdeo added a reviewer: sammccall.
tdeo added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
tdeo requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
