[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGcbd420c5ed85: [CUDA][HIP] Fix bound arch for offload action for fat binary (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Basic/Cuda.cpp:95 const char *CudaArchToString(CudaArch A) { + if (A == CudaArch::UNUSED) +return ""; tra wrote: > You could add a `{CudaArch::UNUSED, "", ""}` to t

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Cuda.cpp:95 const char *CudaArchToString(CudaArch A) { + if (A == CudaArch::UNUSED) +return ""; You could add a `{CudaArch::U

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

yaxunl updated this revision to Diff 295572. yaxunl added a comment. Herald added a subscriber: jholewinski. add CudaArch::UNUSED as suggested by Artem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88524/new/ https://reviews.llvm.org/D88524 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

tra added a comment. In D88524#2304224 , @yaxunl wrote: > This translates to "unknown" in string form, which feels arbitrary. What if a > target has a valid cpu name which "unknown"? Isn't a nullptr (empty string in > string form) a more generic format t

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

yaxunl added a comment. In D88524#2304173 , @tra wrote: >> Currently CUDA/HIP toolchain uses "unknown" as bound arch >> for offload action for fat binary. This causes -mcpu or -march >> with "unknown" added in HIPToolChain::TranslateArgs or >> CUDAToolChai

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

tra added a comment. > Currently CUDA/HIP toolchain uses "unknown" as bound arch > for offload action for fat binary. This causes -mcpu or -march > with "unknown" added in HIPToolChain::TranslateArgs or > CUDAToolChain::TranslateArgs. It would appear that the problem is actually where we check Ta

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently CUDA/HIP toolchain uses "unknown" as bound arch for offload action for fat binary. This causes -mcpu or -march with "unknown" added in HIPToolChain::TranslateArgs or CUDAToolChain::Trans