[PATCH] D89046: [AST] Build recovery expression by default for all language.

shafik added a comment. Herald added a project: All. Hello folks, it looks like this PR is linked to a crash bug: https://github.com/llvm/llvm-project/issues/62711 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D

[PATCH] D89046: [AST] Build recovery expression by default for all language.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1444edbf41c: [AST] Build recovery expression by default for all language. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 306992. hokein added a comment. rebase and update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/Lan

[PATCH] D89046: [AST] Build recovery expression by default for all language.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/builtins-ppc-error.c:51 void testCTF(int index) { - vec_ctf(vsi, index); //expected-error {{argument to '__builtin_altivec_vcfsx'

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein added a comment. should be ready to go -- from our internal experiment, we don't see any super crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 __

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 306680. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 Files: clang/include/clang/Basic/LangOptions.def clang/lib/Frontend/CompilerIn

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein added a subscriber: hubert.reinterpretcast. hokein added a comment. @hubert.reinterpretcast, similar to D78350 , could you help to test this patch with your downstream clang? this patch is based on 2c2dc7c392a3f28d4dbec3018e3137d5d4f8c6c8

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-error.c:51 void testCTF(int index) { - vec_ctf(vsi, index); //expected-error {{argument to '__builtin_altivec_vcfsx' must be a constant integer}} - vec_ctf(vui, index); //expected-error {{argument to '

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 300931. hokein marked an inline comment as done. hokein added a comment. Herald added a subscriber: dexonsmith. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://revie

[PATCH] D89046: [AST] Build recovery expression by default for all language.

sammccall added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-error.c:51 void testCTF(int index) { - vec_ctf(vsi, index); //expected-error {{argument to '__builtin_altivec_vcfsx' must be a constant integer}} - vec_ctf(vui, index); //expected-error {{argument to

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 296968. hokein added a comment. fix unexpected format changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 Files: clang/include/clang/Basic/LangOptions.def clang

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein created this revision. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. hokein requested review of this revision. Not intent to land it now, we need to run internal experiments to make sure this is not crashy. It is ready for review, all ch