[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

aeubanks updated this revision to Diff 301937. aeubanks retitled this revision from "[NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0 " to "[NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0". aeubanks added a comment. revert back to running all c

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

echristo added a comment. In D89158#2363220 , @aeubanks wrote: > Looking at BackendUtil.cpp in Clang as well as the Rust code, I'm back to > thinking that we should provide a way to to all callbacks. Then in the case > of passes added via TargetMachine,

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

aeubanks added a comment. I'm more convinced now that my initial direction was the cleanest way. It would simplify users of `PassBuilder` quite a bit. I don't want to include PassManager.h into TargetMachine.h just to get `PassBuilder::OptimizationLevel`, so either we could factor out `Optimiz

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

aeubanks added a comment. Looking at BackendUtil.cpp in Clang as well as the Rust code, I'm back to thinking that we should provide a way to to all callbacks. Then in the case of passes added via TargetMachine, we should extend `TargetMachine::registerPassBuilderCallbacks` to also take a `Pass