This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcbe4d973edad: [X86] Define __LAHF_SAHF__ if feature
'sahf' is set or 32-bit mode (authored by MaskRay).
Repository:
rG LLVM Github Monorepo
CHANG
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89198/new/
https://reviews.llvm.org/D89198
_
MaskRay added inline comments.
Comment at: clang/lib/Basic/Targets/X86.cpp:564
+ if (HasLAHFSAHF)
+Builder.defineMacro("__LAHF_SAHF__");
if (HasLZCNT)
craig.topper wrote:
> MaskRay wrote:
> > craig.topper wrote:
> > > craig.topper wrote:
> > > > It looks
MaskRay updated this revision to Diff 297441.
MaskRay edited the summary of this revision.
MaskRay added a comment.
Always define __LAHF_SAHF__ in 32-bit mode
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89198/new/
https://reviews.llvm.org/D89198
craig.topper added inline comments.
Comment at: clang/lib/Basic/Targets/X86.cpp:564
+ if (HasLAHFSAHF)
+Builder.defineMacro("__LAHF_SAHF__");
if (HasLZCNT)
MaskRay wrote:
> craig.topper wrote:
> > craig.topper wrote:
> > > It looks like gcc may define thi
MaskRay added inline comments.
Comment at: clang/lib/Basic/Targets/X86.cpp:564
+ if (HasLAHFSAHF)
+Builder.defineMacro("__LAHF_SAHF__");
if (HasLZCNT)
craig.topper wrote:
> craig.topper wrote:
> > It looks like gcc may define this always in 32-bit mode?
>
craig.topper added inline comments.
Comment at: clang/lib/Basic/Targets/X86.cpp:564
+ if (HasLAHFSAHF)
+Builder.defineMacro("__LAHF_SAHF__");
if (HasLZCNT)
craig.topper wrote:
> It looks like gcc may define this always in 32-bit mode?
More confusingly, th
craig.topper added inline comments.
Comment at: clang/lib/Basic/Targets/X86.cpp:564
+ if (HasLAHFSAHF)
+Builder.defineMacro("__LAHF_SAHF__");
if (HasLZCNT)
It looks like gcc may define this always in 32-bit mode?
Repository:
rG LLVM Github Monorepo
C
MaskRay created this revision.
MaskRay added reviewers: craig.topper, dim, fweimer.
Herald added subscribers: cfe-commits, pengfei.
Herald added a project: clang.
MaskRay requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D89198
Files:
clang/lib/B
