[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG552c6c232872: PR44406: Follow behavior of array bound constant folding in more recent… (authored by rsmith). Changed prior to commit: https://revi

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.llvm.org/D89523 _

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith added a comment. In D89523#2333939 , @efriedma wrote: > Also update the documentation? See > https://clang.llvm.org/docs/UsersManual.html#differences-between-various-standard-modes > . Done. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith updated this revision to Diff 298705. rsmith added a comment. - Update User's Manual to more accurately describe GNU mode and Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.llvm.org/D89523 Files: clang/docs/Users

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith updated this revision to Diff 298702. rsmith marked 2 inline comments as done. rsmith added a comment. - Update User's Manual to more accurately describe GNU mode and Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.l

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith marked 3 inline comments as done. rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5939 +ElemTy = TryToFixInvalidVariablyModifiedType(ElemTy, Context, + SizeIsNegative, Oversized); +if (ElemTy.isN

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2278 ArraySize, &SizeVal, Diagnoser, - (S.LangOpts.GNUMode || S.LangOpts.OpenCL) ? Sema::AllowFold -: Sema::NoFold); + S.LangOpts.OpenCL ? Sema

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma added a comment. Also update the documentation? See https://clang.llvm.org/docs/UsersManual.html#differences-between-various-standard-modes . Comment at: clang/lib/Sema/SemaDecl.cpp:5939 +ElemTy = TryToFixInvalidVariablyModifiedType(ElemTy, Context, +

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith created this revision. rsmith added a reviewer: eli.friedman. Herald added a project: clang. rsmith requested review of this revision. Old GCC used to aggressively fold VLAs to constant-bound arrays at block scope in GNU mode. That's non-conforming, and more modern versions of GCC only do t